Apply a similar hack to the "all tabs" menu, as the appMenu has, so it
gets a proper height and doesn't jump above or below the "all tabs"
button, depending on the keyboard being displayed or not. With this
hack, it stays consistently above the button.
Adjust the menu for Firefox 94, and for having the tab bar and search
bar at the bottom.
Getting the appMenu to look decent took me forever to figure out, here's
a notable alternative version that always uses the full screen height:
#appMenu-popup {
margin-top: calc(-1 * 100vh) !important;
height: calc(100vh - 100px) !important;
max-height: calc(100vh - 100px) !important;
}
However with this alternative version, there's a bug when having the
keyboard open, then opening the menu (-> it will get spawned with about
half the screen size), and then closing the keyboard and opening the
menu again. The menu is cached (as one can see in the element inspector)
and still has the wrong height. The content inside the menu is
flickering between the full height and the half height.
By having a fixed size that looks good with both the keyboard open and
closed, we can work around this problem. The height of the keyboard was
adjusted for the PinePhone. If it doesn't look good on your device, add
a media query to make it have a different height based on the overall
height of the window (and possibly also width).
Based on MR 17 by plata-gl, thank you very much, and thanks to everybody
who answered the survey linked in that MR whether to make this default
or not.
I've left out padding-top since the additional 1px bar towards the top
looks like a bug, I've compared with Fennec on Android and it doesn't
have such a line. Also I've left out the inFullscreen lines from the MR,
not sure what they are for - we can still add them in a follow-up patch
if desired.
This patch adds a few features to tag browser. It makes it possible to
de-select a selected file, adds automatic construction of file query
parameter using history API and makes links in css source act like the
file selector buttons in the tag browser. In addition, this patch makes
adding files that end with "_support.css" (like window_control_placeholder_support) always be put it as the first
item in the preview.
For some reason individual .bookmark items in the toolbar are being
rendered in Firefox 96, even though the toolbar itself is hidden. This
patch applies a simple visibility:hidden to all of them.
Bookmark items in the toolbar may not be same height on all systems,
generally the text size on Linux is bigger than on Windows for example.
This patch changes the height to use min-height on bookmark items and
removes their individual block padding. Thus, thee effectively have
variable block-padding depending on the text size.
In addition this patch removes few pre-proton workarounds because those
don't need to be supported any more.
Before this change, the status would show fully, so on narrow windows
the input controls and close button would be pushed out of the window.
Now the status text will instead get clipped.
The 1px bottom margin may have small visible effect for row-height computation
in which case the visible height may be thrown off by a little bit. This
patch fixes that issue.
Using --toolbar-color allow the icons to show up if the selected theme
has light tabs but dark toolbar, and vice versa. In 95 there is no
separate #window-controls for fullscreen, and thus the titlebar-buttonbox-container
becomes last-child which we don't want to hide.
